Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved tenant-patch policy #423

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

sofymunari
Copy link
Contributor

Co-authored-by: Chiara Oggeri Breda chiara.oggeribreda@gmail.com

Description

Moved same initial check of each policy in a separated function, in order to avoid repeating it each time.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Test A
  • Test B

Co-authored-by: Chiara Oggeri Breda <chiara.oggeribreda@gmail.com>
@sofymunari sofymunari requested a review from a team as a code owner February 18, 2021 09:22
@kingmakerbot
Copy link
Collaborator

Hi @sofymunari. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@giorio94 giorio94 added the kind/cleanup Refactoring code label Feb 18, 2021
@giorio94 giorio94 requested a review from palexster February 18, 2021 18:02
@giorio94
Copy link
Member

giorio94 commented Mar 4, 2021

/merge

@kingmakerbot kingmakerbot merged commit 71d9113 into netgroup-polito:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants