Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add persistent VMs in UI #425

Merged
merged 1 commit into from
Mar 13, 2021
Merged

Add persistent VMs in UI #425

merged 1 commit into from
Mar 13, 2021

Conversation

GabriFila
Copy link
Contributor

Description

This PR includes minor changes to add the support for persitent VMs to the UI

@kingmakerbot
Copy link
Collaborator

Hi @GabriFila. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@GabriFila
Copy link
Contributor Author

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!

@frisso
Copy link
Member

frisso commented Mar 11, 2021

That's really nice!
Is there any way to test it in the pre-prod environment? E.g., with a VM image that supports persistency?

giorio94
giorio94 approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GabriFila!

@frisso Yes, I should have enabled your account to use the pre-production operator and access the test VM -- Ubuntu Desktop (Persistent). The updated dashboard is available at https://425.staging.crownlabs.polito.it

dashboard/views/crownLabs/Templates.js Outdated
@@ -169,6 +169,7 @@ export default function Templates(props) {
});

const startLab = template => {
console.log(template);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this should be dropped before merging

@GabriFila GabriFila force-pushed the gbf/add_ui_persistence branch 2 times, most recently from 3c010e5 to 2cf84e7 Compare March 12, 2021 14:22
@GabriFila GabriFila marked this pull request as ready for review March 12, 2021 14:23
@GabriFila GabriFila requested a review from a team as a code owner March 12, 2021 14:23
@GabriFila
Copy link
Contributor Author

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!

@frisso
Copy link
Member

frisso commented Mar 13, 2021

@GabriFila @giorio94 Should we merge this PR?

@GabriFila
Copy link
Contributor Author

I noticed a little positioning problem in the message I placed under the instances tab. I would like to place it under both tabs in case the width allows for the abs to be adjacent.

I'll try to fix it today

@GabriFila GabriFila force-pushed the gbf/add_ui_persistence branch from 2cf84e7 to 0e6b313 Compare March 13, 2021 07:35
@GabriFila GabriFila force-pushed the gbf/add_ui_persistence branch from 0e6b313 to 581c4d8 Compare March 13, 2021 07:36
@GabriFila
Copy link
Contributor Author

/merge

@kingmakerbot kingmakerbot merged commit 5158b86 into master Mar 13, 2021
@kingmakerbot kingmakerbot deleted the gbf/add_ui_persistence branch March 13, 2021 07:43
@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly teared-down!

@giorio94 giorio94 added the kind/feature New feature or request label Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giorio94 giorio94 giorio94 approved these changes

@frisso frisso frisso approved these changes

@palexster palexster palexster approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request sig/ui size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GabriFila @kingmakerbot @frisso @palexster @giorio94