Tune FileBrowser resources and add annotations to FileBrowser ingress #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lucafrancescato. Thanks for your PR. I am @kingmakerbot.
Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:
|
lucafrancescato
changed the title
lucafrancescato
force-pushed
the
vm-to-docker/ingress
branch
from
2992240 to
d2f2386
Compare
lucafrancescato
force-pushed
the
vm-to-docker/ingress
branch
from
3b3ffb9 to
6e03775
Compare
|
/deploy-staging |
|
Your staging environment has been correctly deployed/updated!
|
|
/rebase |
kingmakerbot
force-pushed
the
vm-to-docker/ingress
branch
from
6e03775 to
041565b
Compare
|
/rebase |
kingmakerbot
force-pushed
the
vm-to-docker/ingress
branch
from
041565b to
32f0a11
Compare
palexster
approved these changes
Apr 26, 2021
|
/merge |
|
Your staging environment has been correctly teared-down! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fine-tune the resources (requests and limits) for the FileBrowser container.
Moreover, it adds some useful annotations to the dedicated FileBrowser ingress of the container-based Instance. These annotations remove the limit of 1 MB for the maximum allowed size of the client request body, as well as increase connection timeouts between two requests or responses, and other minor tweaks that overall increase the final user experience when dealing with FileBrowser.