-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix blender 2.92 compatibility issue with Ubuntu #448
Fix blender 2.92 compatibility issue with Ubuntu #448
Conversation
Hi @QcFe. Thanks for your PR. I am @kingmakerbot.
Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks to me this Dockerfile is identical to the LTS one, with just a different version. If so, wouldn't it be possible to keep only one and build twice with a different version as argument? Just to prevent code duplication and unwanted misalignements
@giorio94 it is identical indeed but I didn't look close enough in the |
You could use build-args as here: CrownLabs/.github/workflows/build.yml Line 122 in df41684
|
fc064d6
to
c35d0b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/rebase |
c35d0b2
to
797e115
Compare
/merge |
Description
This PR provides a single Dockerfile for Blender container images and uses build args to specify the Blender version to ship into the image.
This also fixes an issue with the Blender 2.92 image, which has been unnoticed up to now. For some unknown reason Ubuntu 18.04 has some compatibility issues with Blender > 2.83.8. The unified Dockerfile builds the image from scratch using Ubuntu 20.04.
How Has This Been Tested?
The imagea has been run in a compatible local Docker environment.