Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blender 2.92 compatibility issue with Ubuntu #448

Merged

Conversation

QcFe
Copy link
Collaborator

@QcFe QcFe commented Apr 26, 2021

Description

This PR provides a single Dockerfile for Blender container images and uses build args to specify the Blender version to ship into the image.
This also fixes an issue with the Blender 2.92 image, which has been unnoticed up to now. For some unknown reason Ubuntu 18.04 has some compatibility issues with Blender > 2.83.8. The unified Dockerfile builds the image from scratch using Ubuntu 20.04.

How Has This Been Tested?

The imagea has been run in a compatible local Docker environment.

@QcFe QcFe requested a review from a team as a code owner April 26, 2021 15:17
@kingmakerbot
Copy link
Collaborator

Hi @QcFe. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks to me this Dockerfile is identical to the LTS one, with just a different version. If so, wouldn't it be possible to keep only one and build twice with a different version as argument? Just to prevent code duplication and unwanted misalignements

@QcFe
Copy link
Collaborator Author

QcFe commented Apr 26, 2021

@giorio94 it is identical indeed but I didn't look close enough in the build.yaml file to see it could be automated easily, I'll proceed to make the change

@giorio94
Copy link
Member

You could use build-args as here:

@QcFe QcFe force-pushed the vm-to-docker/blender-image branch from fc064d6 to c35d0b2 Compare April 26, 2021 18:51
@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 26, 2021
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@giorio94 giorio94 requested review from GabriFila and palexster April 27, 2021 07:28
@giorio94 giorio94 added kind/cleanup Refactoring code kind/bug Something isn't working and removed kind/cleanup Refactoring code labels Apr 27, 2021
@giorio94
Copy link
Member

/rebase

@kingmakerbot kingmakerbot force-pushed the vm-to-docker/blender-image branch from c35d0b2 to 797e115 Compare April 27, 2021 10:46
@giorio94
Copy link
Member

/merge

@kingmakerbot kingmakerbot merged commit 21476f4 into netgroup-polito:master Apr 27, 2021
@QcFe QcFe deleted the vm-to-docker/blender-image branch April 27, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants