Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with docker layers caching #468

Merged
merged 1 commit into from
May 15, 2021
Merged

Fix issue with docker layers caching #468

merged 1 commit into from
May 15, 2021

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented May 14, 2021

Description

This PR fixes an issue in the configuration of the docker layers caching in the build-and-publish actions, which caused the usage of outdated caches in certain conditions. Essentially, if an exact match occurs, the resulting cache is not updated, although it may have changed due to a new version of the base image. With this modification, the cache is assigned a name guaranteed to be unique, to ensure it is always updated.

@kingmakerbot
Copy link
Collaborator

Hi @giorio94. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@giorio94 giorio94 added the kind/bug Something isn't working label May 14, 2021
@giorio94 giorio94 requested review from GabriFila and QcFe May 14, 2021 17:06
@giorio94 giorio94 marked this pull request as ready for review May 14, 2021 17:06
@giorio94 giorio94 requested a review from a team as a code owner May 14, 2021 17:06
.github/workflows/build.yml Show resolved Hide resolved
@giorio94
Copy link
Member Author

/merge

@kingmakerbot kingmakerbot merged commit 92ea18a into master May 15, 2021
@kingmakerbot kingmakerbot deleted the mio/gh-cache branch May 15, 2021 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working sig/devops size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants