Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authentication for subscriptions #476

Merged
merged 2 commits into from
May 29, 2021
Merged

Authentication for subscriptions #476

merged 2 commits into from
May 29, 2021

Conversation

ralls0
Copy link
Member

@ralls0 ralls0 commented May 27, 2021

Description

In this pull request there are some changes to integrate the authentication for subscriptions

@ralls0 ralls0 requested a review from a team as a code owner May 27, 2021 10:25
@kingmakerbot
Copy link
Collaborator

Hi @ralls0. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@ralls0 ralls0 added kind/feature New feature or request sig/auth labels May 27, 2021
GabriFila
GabriFila reviewed May 27, 2021
View reviewed changes
qlkube/src/decorateSubscription.js Outdated Show resolved Hide resolved
qlkube/src/decorateSubscription.js Outdated Show resolved Hide resolved
qlkube/src/index.js Outdated Show resolved Hide resolved
qlkube/src/index.js Outdated Show resolved Hide resolved
@GabriFila GabriFila force-pushed the ral/subscription branch 2 times, most recently from 7aa8dbf to e398f78 Compare May 27, 2021 13:31
@GabriFila GabriFila force-pushed the ral/subscription branch 2 times, most recently from 0838fbb to 0c7fad3 Compare May 27, 2021 14:16
@GabriFila
Copy link
Contributor

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Current dashboard, New frontend, Storybook, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-476 label to your tenant.

giorio94
giorio94 approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAU, /lgtm

qlkube/README.md Outdated Show resolved Hide resolved
qlkube/README.md Outdated Show resolved Hide resolved
@GabriFila
Copy link
Contributor

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Something went wrong while deploying your staging environment!

@GabriFila
Copy link
Contributor

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Something went wrong while deploying your staging environment!

@GabriFila
Copy link
Contributor

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Current dashboard, New frontend, Storybook, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-476 label to your tenant.

@ralls0 ralls0 force-pushed the ral/subscription branch 3 times, most recently from ea8db6b to e486538 Compare May 28, 2021 08:01
@ralls0
Copy link
Member Author

ralls0 commented May 28, 2021

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Current dashboard, New frontend, Storybook, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-476 label to your tenant.

@ralls0 ralls0 force-pushed the ral/subscription branch from e486538 to 895c125 Compare May 28, 2021 10:19
@ralls0 ralls0 force-pushed the ral/subscription branch from 895c125 to 930736e Compare May 29, 2021 12:47
@GabriFila
Copy link
Contributor

/merge

@kingmakerbot kingmakerbot merged commit 2b87d76 into netgroup-polito:master May 29, 2021
@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly teared-down!

@ralls0 ralls0 deleted the ral/subscription branch June 12, 2021 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giorio94 giorio94 giorio94 approved these changes

@GabriFila GabriFila GabriFila approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request sig/auth sig/community sig/ui size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ralls0 @kingmakerbot @GabriFila @giorio94