Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check generated artifacts GitHub Action #482

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

giorio94
Copy link
Member

Description

This PR introduces a fix to prevent missing files from not being considered by the check generated artifacts GitHub action.

@giorio94 giorio94 requested review from palexster, QcFe and GabriFila June 14, 2021 17:25
@giorio94 giorio94 requested a review from a team as a code owner June 14, 2021 17:25
@kingmakerbot
Copy link
Collaborator

Hi @giorio94. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@giorio94 giorio94 added kind/bug Something isn't working and removed sig/devops labels Jun 14, 2021
Copy link
Collaborator

@QcFe QcFe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@giorio94
Copy link
Member Author

/rebase

This commit introduces a fix to prevent missing files from not being
considered by the check generated artifacts GitHub action.
@giorio94
Copy link
Member Author

/merge

@kingmakerbot kingmakerbot merged commit 91b568f into master Jun 29, 2021
@kingmakerbot kingmakerbot deleted the mio/fix-check-generated branch June 29, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working sig/devops size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants