Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to fix bastion operator ocassionally-failing tests #497

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Try to fix bastion operator ocassionally-failing tests #497

merged 1 commit into from
Jul 8, 2021

Conversation

QcFe
Copy link
Collaborator

@QcFe QcFe commented Jul 8, 2021

Description

This PR aims to fix a failing test on the bastion operator, probably related to some race condition happening during checks.

@kingmakerbot
Copy link
Collaborator

Hi @QcFe. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@QcFe QcFe force-pushed the qcfe/fix-tests branch 2 times, most recently from 9d4f44c to c3b9c0e Compare July 8, 2021 12:26
@QcFe QcFe marked this pull request as ready for review July 8, 2021 12:30
@QcFe QcFe requested a review from a team as a code owner July 8, 2021 12:30
@giorio94 giorio94 added the kind/cleanup Refactoring code label Jul 8, 2021
@giorio94 giorio94 requested a review from GabriFila July 8, 2021 12:41
@QcFe
Copy link
Collaborator Author

QcFe commented Jul 8, 2021

/rebase

@giorio94
Copy link
Member

giorio94 commented Jul 8, 2021

/rebase

@QcFe
Copy link
Collaborator Author

QcFe commented Jul 8, 2021

/merge

@kingmakerbot kingmakerbot merged commit 4e7372b into master Jul 8, 2021
@kingmakerbot kingmakerbot deleted the qcfe/fix-tests branch July 8, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giorio94 giorio94 giorio94 approved these changes

@GabriFila GabriFila GabriFila approved these changes

Assignees
No one assigned
Labels
kind/cleanup Refactoring code sig/api size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@QcFe @kingmakerbot @giorio94 @GabriFila