-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Harbor GituHub Actions #757
Conversation
Hi @s225904. Thanks for your PR. I am @kingmakerbot.
Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:
|
8adfd33
to
e8ce370
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments inline
/rebase |
45f7c03
to
8622861
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment. Remember also to squash the commits
8622861
to
ec810fe
Compare
fix comment Add Harbor GitHub actions to build.yml in workflow directory Update build.yml add Harbor Login Update build.yml add build and push for harbor Update build.yml change secret to secrets Update build.yml change tags of harbor push Update build.yml test for pushing in repo crownlabs Update build.yml add docker login Update build.yml add cache docker layers Update build.yml without layers Update build.yml one Docker Buildx Update build.yml add cache action for harbor Update build.yml add checkout to harbor Update build.yml build and push in specific project Update build.yml fix if Update build.yml fix if statement with matrix.component Update build.yml remove parentesis {{ }} from if statement Update build.yml Update build.yml Update build.yml Update build.yml fix if statement Update build.yml final fix Update build.yml change local cache into gha Update build.yml update issue 252 for cache in DockerHub part Update build.yml fix after call Update build.yml comment DockerHub tag delete repo-owner for harbor fix harbor-project in tags hardcoded value changed with the secret secret changed
ec810fe
to
6a45a1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
/merge |
Description
Change build.yml file in workflow directory, adding github action for Harbor. Update also the DockerHub docker/build-push-action@v2 part because the issue 252 has been update
How Has This Been Tested?
I've run this workflow many times and I've seen that the github actions when successfully ends push the images in the correct project. Unfortunately there is a problem with the robot account and some times a random github actions fail.