Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added deletion modal in account page #761

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Added deletion modal in account page #761

merged 1 commit into from
Mar 17, 2022

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Mar 4, 2022

This PR replaces the PopConfirm shown when a key is going to be deleted with a bigger modal.

@cheina97 cheina97 requested a review from a team as a code owner March 4, 2022 11:38
@kingmakerbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@giorio94
Copy link
Member

giorio94 commented Mar 7, 2022

/deploy-staging

@cheina97 cheina97 force-pushed the alcfrc/accountPageModalDelete branch 2 times, most recently from 0aaa4f6 to 8206bd9 Compare March 9, 2022 18:08
@pull-request-size pull-request-size bot added size/M and removed size/XS labels Mar 9, 2022
@cheina97 cheina97 force-pushed the alcfrc/accountPageModalDelete branch from 8206bd9 to 93b19b0 Compare March 9, 2022 18:19
@cheina97 @cannarelladev
Added deletion modal in account page
1b0c2b9 
Co-authored-by: Alessandro Cannarella <cannarella.dev@gmail.com>
@cheina97 cheina97 force-pushed the alcfrc/accountPageModalDelete branch from 93b19b0 to 1b0c2b9 Compare March 15, 2022 18:07
@QcFe
Copy link
Collaborator

QcFe commented Mar 17, 2022

/merge

@kingmakerbot kingmakerbot merged commit dc8fd6c into netgroup-polito:master Mar 17, 2022
@cheina97 cheina97 deleted the alcfrc/accountPageModalDelete branch March 17, 2022 08:55
@giorio94 giorio94 added the kind/feature New feature or request label Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QcFe QcFe QcFe approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request sig/ui size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cheina97 @kingmakerbot @giorio94 @QcFe