Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: configure caching policy in nginx.conf #783

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented Apr 28, 2022

Description

This PR enhances the nginx configuration file of the frontend, to introduce directives concerning the caching policy of the different resources. In particular, it enforces non versioned resources are always revalidated with the upstream, while static assets can be freely cached as versioned.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Locally, checking that resources are correctly cached
  • Through the deploy staging environment

@giorio94 giorio94 added the kind/feature New feature or request label Apr 28, 2022
@giorio94
Copy link
Member Author

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Hi @giorio94. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR (the build-all flag enables user environments building)
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-783 label to your tenant.

@giorio94 giorio94 marked this pull request as ready for review April 28, 2022 07:21
@giorio94 giorio94 requested a review from a team as a code owner April 28, 2022 07:21
Copy link
Collaborator

@QcFe QcFe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@giorio94
Copy link
Member Author

/merge

@kingmakerbot kingmakerbot merged commit 3038208 into master Apr 28, 2022
@kingmakerbot kingmakerbot deleted the mio/frontend-nginx branch April 28, 2022 08:41
@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly teared-down!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request sig/ui size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants