Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable servicelinks, generate container hostname if not standard mode #798

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

QcFe
Copy link
Collaborator

@QcFe QcFe commented Jun 29, 2022

Description

This PR

  • sets enableServiceLinks: false on instance deployments so that a possibly high number of environment variables is not set (service links);
  • forges the container hostname based on the environment mode so that the instance name is hidden (when not default env mode)

Testing

  • go tests
  • staging

@QcFe QcFe requested a review from a team as a code owner June 29, 2022 18:11
@QcFe QcFe requested a review from giorio94 June 29, 2022 18:11
@kingmakerbot
Copy link
Collaborator

Hi @QcFe. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR (the build-all flag enables user environments building)
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@giorio94 giorio94 added the kind/feature New feature or request label Jun 30, 2022
@QcFe
Copy link
Collaborator Author

QcFe commented Jun 30, 2022

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-798 label to your tenant.

@QcFe
Copy link
Collaborator Author

QcFe commented Jun 30, 2022

/merge

@kingmakerbot kingmakerbot merged commit cd3bf41 into master Jun 30, 2022
@kingmakerbot kingmakerbot deleted the qcfe/remove-service-links branch June 30, 2022 09:21
@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly teared-down!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request sig/api size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants