Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tenant WebHook: skip tenant spec check on creation #804

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

QcFe
Copy link
Collaborator

@QcFe QcFe commented Sep 8, 2022

Description

This PR adds a check for skipping tenant spec check in case the tenant being validated is new.

@QcFe QcFe requested a review from a team as a code owner September 8, 2022 15:44
@QcFe QcFe added the kind/bug Something isn't working label Sep 8, 2022
@kingmakerbot
Copy link
Collaborator

Hi @QcFe. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR (the build-all flag enables user environments building)
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

operators/pkg/tenantwh/validating_test.go Outdated Show resolved Hide resolved
@QcFe QcFe force-pushed the qcfe/fix-tenant-validator branch from bad93c3 to e0ce841 Compare September 9, 2022 08:47
@QcFe
Copy link
Collaborator Author

QcFe commented Sep 19, 2022

/merge

@QcFe
Copy link
Collaborator Author

QcFe commented Sep 19, 2022

/rebase

@QcFe
Copy link
Collaborator Author

QcFe commented Sep 19, 2022

/merge

@kingmakerbot kingmakerbot merged commit efe3506 into master Sep 19, 2022
@kingmakerbot kingmakerbot deleted the qcfe/fix-tenant-validator branch September 19, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working sig/api size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants