[RD-67] Add completion handler to URLProtocol class method: Will perform redirection … #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinaShehata
changed the title
MinaShehata
changed the title
DamianMarkowski
approved these changes
Jan 23, 2023
pkozielecki
approved these changes
Jan 23, 2023
elgiguiere
pushed a commit
to elgiguiere/ResponseDetective
that referenced
this pull request
Oct 24, 2023
…-canceled-when-RD-is-enabled [RD-67] Add completion handler to URLProtocol class method: Will perform redirection …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task Description
Executing http requests that perform
redirection(POST OR GET) requestsand
Response Detectiveis enabled we get this error in output consoleScreenShot
Original Issue
if we disabled
Response Detectivewe didn't get that error because we use native URLProtocol class existed in URLSessionTaskDelegate that hastask:willPerformHTTPRedirection:newRequest:completionHandler: completioncalled completion handler at the end.Solution
Adding completion handler to
task:willPerformHTTPRedirection:newRequest:completionHandler: completionin NSURLSession delegate RDTURLProtocol this solve the issue