Implement ICE Enforcement Configuration #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amygos
force-pushed
the
iceenforce
branch
3 times, most recently
from
34bf0ea to
7edd171
Compare
Introduce ICEENFORCE variable to control ICE enforcement behavior.
Introduce a new script step to configure ICE to enforce the proxy IP address. This step retrieves the proxy service records and updates the environment variable `ICEENFORCE` with the correct address. If the address is changed, it triggers a restart of relevant services to apply the new configuration.
Use the ICEENFORCE environment variable to populate the list of the only interfaces that Janus will use for ICE gathering.
Add documentation for the `ICEENFORCE` environment variable in the README.md. This variable allows users to specify a list of interfaces or IP addresses to enforce during ICE candidates gathering. By default, it is set to 'none'.
On the event `nethvoice-proxy-settings-changed`, update the ICEENFORCE environment variable and also restart the janus service.
Stell0
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the ability to enforce ICE candidates with the proxy IP
address. It introduces a new environment variable,
ICEENFORCE, which is setto the proxy IP address. The
janus.serviceis also updated to include the--ice-enforce-listoption, allowing the enforcement of ICE candidates onspecific interfaces or IP addresses. Additionally, the
create-moduleandupdate-moduleactions are modified to include theICEENFORCEvariableenforcement behavior.
NethServer/dev#7099