Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NeCombobox improvements #60

Merged
merged 2 commits into from
Jun 24, 2024
Merged

NeCombobox improvements #60

merged 2 commits into from
Jun 24, 2024

Conversation

andre8244
Copy link
Collaborator

@andre8244 andre8244 commented Jun 18, 2024 •
edited
Loading

NeCombobox improvements:

  • Add support for options icons
  • Fix a bug that was preventing the display of the initial selected value if it is not included among the combo options (user input)

@andre8244
fix: improve user input management for NeCombobox
04215a1 
Fix a bug that prevented displaying the initial selected value if it is not
included among the combo options (user input)
@andre8244 andre8244 requested a review from Tbaile June 18, 2024 15:10
@andre8244 andre8244 changed the title fix: improve user input management for NeCombobox Improve user input management for NeCombobox Jun 20, 2024
@andre8244 andre8244 changed the title Improve user input management for NeCombobox NeCombobox improvements Jun 20, 2024
@andre8244 andre8244 requested a review from Tbaile June 20, 2024 14:18
@andre8244 andre8244 force-pushed the combo-fix-initial-user-input branch from 63e4502 to 61fb8ff Compare June 20, 2024 14:27
Tbaile
Tbaile approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@Tbaile Tbaile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're adding too much power to the JS instead of composing the results, let's just keep an eye on that

@andre8244 andre8244 merged commit fef7695 into main Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tbaile Tbaile Tbaile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andre8244 @Tbaile