Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed issue with missing dependencies #70

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Tbaile
Copy link
Collaborator

@Tbaile Tbaile commented Aug 9, 2024

Poppins font has been included automatically to all builds
Adding @tailwindcss/forms to prod dependencies

Poppins font has been included automatically to all builds
Adding @tailwindcss/forms to prod dependencies
@Tbaile Tbaile requested a review from andre8244 August 9, 2024 12:06
Copy link
Collaborator

@andre8244 andre8244 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the advantage? Projects using vue-components will still need to import Poppins for every html text outside components

@Tbaile
Copy link
Collaborator Author

Tbaile commented Aug 9, 2024

This is not true anymore 🥳
Poppy as a font is being imported directly by our CSS file, which must be imported in target project CSS, so it will be automatically added

If you think there'll be the case where the font might be end up built even without using it (I.E. because for a specific project we change the font) I'll remove such change.

@andre8244 andre8244 self-requested a review August 9, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants