feat: add NeAvatar component #91
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the new NeAvatar component (with stories), extends NeDropdown with a menuHeader slot, and refines typography and layout for NeModal and NeCard.
- Add NeAvatar component, export, and Storybook stories
- Enhance NeDropdown to support a
menuHeaderslot - Adjust font-weight in NeModal and NeCard titles and hide empty headers in cards
- Add story for cards without a title
Reviewed Changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| stories/NeDropdown.stories.ts | Rename WithSlot to ButtonSlot and add MenuHeaderSlot story |
| stories/NeCard.stories.ts | Add WithoutTitle story with no-title card scenario |
| stories/NeAvatar.stories.ts | New Storybook file for NeAvatar |
| src/main.ts | Export NeAvatar component and AvatarSize type |
| src/components/NeModal.vue | Change dialog title class from font-semibold to font-medium |
| src/components/NeDropdown.vue | Insert <slot name="menuHeader"> before dropdown items |
| src/components/NeCard.vue | Compute when header should show, update font-weight and spacing |
| src/components/NeAvatar.vue | New component implementation with image, initials, and placeholder logic |
| package.json | Bump version to 3.0.6 |
Comments suppressed due to low confidence (1)
package.json:4
- Since this release adds a new public component (NeAvatar), consider a minor version bump (e.g., 3.1.0) instead of a patch bump to align with semantic versioning.
"version": "3.0.6",
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Tbaile
approved these changes
Jul 3, 2025
There was a problem hiding this comment.
remember to remove the pack pushes
| <img | ||
| v-if="img && !imageError" | ||
| :alt="alt" | ||
| :class="`${avatarSizeClasses[size]} ${squared ? 'rounded-sm' : 'rounded-full'}`" |
There was a problem hiding this comment.
Suggested change
| :class="`${avatarSizeClasses[size]} ${squared ? 'rounded-sm' : 'rounded-full'}`" | |
| :class="[avatarSizeClasses[size], squared ? 'rounded-sm' : 'rounded-full']" |
| <div v-else-if="(imageError || !img) && !initials" :class="placeholderContainerClasses"> | ||
| <FontAwesomeIcon | ||
| :icon="faUser" | ||
| :class="`${placeholderColorClasses} ${placeholderIconSizeClasses[size]}`" |
There was a problem hiding this comment.
Suggested change
| :class="`${placeholderColorClasses} ${placeholderIconSizeClasses[size]}`" | |
| :class="[placeholderColorClasses, placeholderIconSizeClasses[size]]" |
| :class="`${placeholderColorClasses} ${placeholderIconSizeClasses[size]}`" | ||
| /> | ||
| </div> | ||
| <div v-else :class="`${placeholderContainerClasses} font-medium`"> |
There was a problem hiding this comment.
Suggested change
| <div v-else :class="`${placeholderContainerClasses} font-medium`"> | |
| <div v-else :class="[placeholderContainerClasses, 'font-medium']"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
menuHeaderslot