-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rclone verbose logs cannot be parsed by NPBackup #132
Comments
Happy to know that things work ;) I'm pretty sure that rclone verbose just gives too much information which NPBackup cannot parse, although it does not crash, but just notices the error and still sends metrics. I'd definitly need to have an output of this with |
Since rclone works, this can wait until after a v3 release, but still I'd like to be able to filter rclone verbose output to parse only necessary data. I've managed to update RC15 everywhere, and it seems to work well. |
@deajan agree this is not a show stopper for RTM. p.s. Upon doing it I found a bug that deserves fixing. Will log an issue for that. |
@deajan In my opinion this issue boils down to wanting to deal with RCLONE_VERBOSE=2 enabled which is fantastic for debugging but normally not required for regular backup situations. Enough said; here my anonymized npbackup config file: Results from a fresh run with --debug output:
...which does not lead to a fatal error or crash, but this GUI state: npbackup then does crash when you trigger the snapshot reading one more time either via opening/closing the configuration or by pressing the GUi repo 'Backup state' button, here the additional debug log:
and GUI state: after pressing Close button: then it crashes wth this final info in the terminal:
|
@GuitarBilly There's a fix now in master for filtering rclone debug logs. |
Released in 3.0.1-rc1 comming out tomorrow morning. |
@deajan, sure i'll try; realistically it will happen about two weeks from now (occupied with other things atm). |
@GuitarBilly No worries, this is "a side quest" fix ;) |
@deajan, hope this help.
terminal output (skipped the download part from github):
FYI - in the npbackup-gui then the snapshots command also throws an error (hence my trail to run a backup via --run-as-cli. |
Thank you for the report. I guess this is still with RCLONE_VERBOSE set ? |
yes that is correct, First i have ran again with --debug, then i changed the --backup to --snapshots because that is what was failing in the GUI. Interestingly there are different results. Last i added the GUI for good measure. here is the output of
and here the output of the --snapshots:
here the GUI response when changing the repo which equals the snapshots command afaik: pressing close displays the error, after which pressing OK exits npbackup-gui and closes its terminal. |
It's not easy trying to debug things without me setting up a full rclone repo. Would you mind running the latest git code with the same backup and snapshot debug commands ? |
sure I can run the latest git code again. It is better. here is the output of
and here the output of the --snapshots:
So both commands now have the status of success. Then I try with the GUI too. The GUI gives messages in the window but does not crash anymore. Since my commandline was --dry-run and the GUI does not crash, I dare to launch a manual backup in the GUI: It seems we have a winner! one more snapshot available !! Next try, remove the RCLONE_VERBOSE = 2 from the configuration and run again. This makes the GUI complete the backup without any "DEBUG" messages in the "error messages" part of the window, but brings no change to the Grafana Dashboard. |
Thank you for the (re) testing, happy to know it works. I'll close this one and open another issue for the grafana dashboard. |
npbackup-cli
W10 enterprise 64bit
confirmed on v3.0.0-rc14 and v3.0.0-rc15
This backup to OneDrive worked fine on rc12 and rc13.
I have set "Environment variables"
RCLONE_VERBOSE
to 2 to print extra information.I have set "Additional backup only parameters" to
--dry-run -o rclone.args="serve restic --stdio --b2-hard-delete --user-agent ISV|rclone.org|rclone/v1.65.2"
in an attempt to get the--user-agent
passed onto rclone.steps to reproduce and terminal log:
expected result:
npbackup should not crash but handle it gracefully with an error or warning to the user.
Note that with RCLONE_VERBOSE set to 2 the npbackup-gui hangs on listing snapshots for this OneDrive repo since rc14, hence my trial with npbackup-cli, here are the npbackup-gui messages in the GUI after loading the snapshots:
Last messages
Error messages
EDIT : here is the npbackup-gui termnial log:
The text was updated successfully, but these errors were encountered: