Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(project): migrate to pnpm #1442

Merged
merged 9 commits into from
Mar 31, 2022
Merged

chore(project): migrate to pnpm #1442

merged 9 commits into from
Mar 31, 2022

Conversation

hyrious
Copy link
Member

@hyrious hyrious commented Mar 25, 2022

Noticeable Changes:

  • Many dev scripts are updated (to replace "yarn run xxx" with "pnpm"), including github actions. These scripts may fail and need more investigating. @BlackHole1 Please help reviewing this.
  • Common devDependencies are hoisted to the root package.json instead of having several copies at each package, because pnpm will create different symlinks to them if they occured in difference place.
  • ESLint is upgraded to 8 along with some eslint plugins. The eslint vite plugin was removed due to parsing errors. @BlackHole1 Please help reviewing this change and maybe fix it in the future.
  • I tried running/building storybook locally and it works. @crimx Please help reviewing this change.

@hyrious hyrious marked this pull request as ready for review March 25, 2022 08:54
crimx
crimx previously approved these changes Mar 25, 2022
.github/workflows/check-code.yml Outdated Show resolved Hide resolved
.github/workflows/deploy-storybook.yml Outdated Show resolved Hide resolved
.github/workflows/deploy-web-dev-cn.yml Outdated Show resolved Hide resolved
.github/workflows/deploy-web-dev-us.yml Outdated Show resolved Hide resolved
.github/workflows/deploy-web-prod-cn.yml Outdated Show resolved Hide resolved
.github/workflows/deploy-web-prod-us.yml Outdated Show resolved Hide resolved
Co-authored-by: Black-Hole <158blackhole@gmail.com>
hyrious and others added 5 commits March 28, 2022 10:43
Co-authored-by: Black-Hole <158blackhole@gmail.com>
Co-authored-by: Black-Hole <158blackhole@gmail.com>
Co-authored-by: Black-Hole <158blackhole@gmail.com>
Co-authored-by: Black-Hole <158blackhole@gmail.com>
Co-authored-by: Black-Hole <158blackhole@gmail.com>
Copy link
Collaborator

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cspell.config.js Outdated Show resolved Hide resolved
desktop/renderer-app/vite.config.ts Show resolved Hide resolved
package.json Show resolved Hide resolved
hyrious and others added 2 commits March 28, 2022 11:19
Co-authored-by: Black-Hole <158blackhole@gmail.com>
@BlackHole1
Copy link
Collaborator

ready merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants