Skip to content

chore(project): use white-web-sdk-esm to slightly reduce bundle size #1579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2022
Merged

chore(project): use white-web-sdk-esm to slightly reduce bundle size #1579

merged 1 commit into from
Jun 21, 2022

Conversation

hyrious
Copy link
Contributor

@hyrious hyrious commented Jun 21, 2022

No description provided.

BlackHole1
BlackHole1 approved these changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How much will it reduce?
Was it stable?

@Cheerego7 Cheerego7 merged commit 164f4e9 into netless-io:main Jun 21, 2022
@hyrious
Copy link
Contributor Author

hyrious commented Jun 21, 2022 •
edited
Loading

How much will it reduce?

package format target
white-web-sdk cjs es5 (with babel & core-js)
white-web-sdk-esm esm es2017

Basically it reduces the size contributed by babel transforming async/await to generators and core-js modules.

Was it stable?

Let's see..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlackHole1 BlackHole1 BlackHole1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hyrious @BlackHole1 @Cheerego7