chore: fully upgrade demo and fixtures to v18 stable #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: chore
✅ Deploy Preview for plugin-angular-universal-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
and swap the v18 fixture for a v17 fixture
serhalp
force-pushed
the
chore/angular-18-cleanup
branch
from
4e5e6b0 to
c142652
Compare
mrstork
reviewed
May 29, 2024
mrstork
reviewed
May 29, 2024
mrstork
approved these changes
May 30, 2024
|
Might need to clear test cache after merging this as the angular 18 fixture files might be floating around causing fake failures (I experienced this when switching branches from main) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #110 we upgraded to an Angular 18 pre-release in a single new fixture.
This PR upgrades to all fixtures and the demo to v18 stable and swaps out the v18 fixture for a v17 fixture, since we still support v17.
I pinned the angular deps in the v17 fixture so that Renovate ignores it.
Closes #128.