chore: upgrade angular@19 versions #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plugin-angular-universal-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
type: chore
pieh
force-pushed
the
chore/upgrade-angular-19
branch
from
dc9e3a7 to
99ee34c
Compare
…ndencies are updated
pieh
commented
Feb 13, 2025
Comment on lines
+7
to
+16
| const excludedPathsWithMaskedHashes = config.excludedPath.map((path) => path.replace(/-[A-Z\d]{8}\./, '-HASHHASH.')) | ||
|
|
||
| assert.deepEqual(excludedPathsWithMaskedHashes, [ | ||
| '/.netlify/*', | ||
| '/favicon.ico', | ||
| '/heroes/index.html', | ||
| '/index.csr.html', | ||
| '/main-KVCR6MBP.js', | ||
| '/polyfills-FFHMD2TL.js', | ||
| '/styles-5INURTSO.css', | ||
| '/main-HASHHASH.js', | ||
| '/polyfills-HASHHASH.js', | ||
| '/styles-HASHHASH.css', |
There was a problem hiding this comment.
checking concrete hashes here is causing problems so instead I do mask hash to ensure to still be able to ensure that expected static assets are produced and excluded from function configuration so we don't have to update assertions with each Angular version bump
minivan
approved these changes
Feb 13, 2025
orinokai
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New revision of #227
Fixes https://linear.app/netlify/issue/FRB-1622/possible-regression-with-new-framework-release