fix: workaround for a cloudfront issue where it throws on a 403 #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for blobs-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
minivan
approved these changes
Sep 21, 2023
mraerino
reviewed
Sep 21, 2023
|
@mraerino sure I'm adding it to the linked issue :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for sending this pull request! 🎉
Temp fix for: https://github.com/netlify/pod-dev-foundations/issues/592
Currently, if we hit Cloudfront with a nonexisting blob storage key it returns a wrong status code.
Instead of providing a 404 (Not found), it returns a 403 (Access denied).
This is not ideal, we are using the status code to determine if it should throw or not. A 404 just returns null which means nothing found but all fine.
This fix makes it behave similar on a build plugin or during request time