fix: fix the publish directory for next.js

[lukasholzer]

🎉 Thanks for submitting a pull request! 🎉

Summary

For NX Monorepos, the detection of a Next.js app is wrong as it does not point to the .next folder. Instead, it just points to the top-level dist folder.

For example: dist/packages/website would currently be the output, but this is wrong. It must be dist/packages/website/.next as we always need to point to the .next folder.

This will lead to "broken" sites when using the create new site flow on netlify with an nx workspace and Next.js. So, users need to fix the publish directory in the build settings manually.

which fails with:

---

For us to review and ship your PR efficiently, please perform the following steps:

• Open a bug/issue before writing your code 🧑‍💻. This ensures
  we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
  something that`s on fire 🔥 (e.g. incident related), you can skip this step.
• Read the contribution guidelines 📖. This ensures
  your code follows our style guide and passes our tests.
• Update or add tests (if any source code was changed or added) 🧪
• Update or add documentation (if features were changed or added) 📝
• Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

[Skn0tt]

Looks wonderful, loving all the tests we have on this!

[mrstork]

This seems like an easy win, is it still relevant? Shall we get this merged?

[serhalp]

@lukasholzer could you explain in the PR description what the bug is and how this fixes it? I'm not understanding what's different about next.js here

[Skn0tt]

I'd be curious as well!

[lukasholzer]

@serhalp and @Skn0tt I've updated the description ;)

[pieh]

And to answer why this is different for Next specifically - it's because of NX ecosystem around frameworks

For Next.js they have quite a bit of tooling build around it and for Next.js they keep original Next.js distDir nested under NX "dist dir" ( https://github.com/nrwl/nx/blob/b6140d459020847818b738ddc17e52c069657893/packages/next/plugins/with-nx.ts#L206-L209 )

But for example for Astro - they don't really have a plugin like that - instead application generator/bootstrapper/scaffolder ( https://www.npmjs.com/package/@nxtensions/astro ) will define output dir to something like dist/apps/<app-name> (this might need a bit more looking into if that is correct, but regardless - it seems like we need to approach NX with each framework individually so targetting next specifically here seems fine to me and we shouldn't try to generalize it for any framework