feat: support 'pattern' in inline edge function config #5749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nction inline config
pieh
force-pushed
the
feat/support-pattern-in-inline-edge-function-config
branch
4 times, most recently
from
741278a
to
743405c
Compare
pieh
force-pushed
the
feat/support-pattern-in-inline-edge-function-config
branch
from
743405c
to
9177c35
Compare
JGAntunes
approved these changes
Jul 2, 2024
| @@ -92,25 +100,45 @@ const createDeclarationsFromFunctionConfigs = ( | |||
| const declarations: Declaration[] = [] | |||
|
|
|||
| for (const name in functionConfigs) { | |||
| const { cache, excludedPath, path, method } = functionConfigs[name] | |||
| const functionConfig = functionConfigs[name] | |||
| const { cache, method } = functionConfigs[name] | |||
|
|
|||
| // If we have a path specified, create a declaration for each path. | |||
There was a problem hiding this comment.
Tiny thing but seems like this comment should either move or is outdated?
pieh
force-pushed
the
feat/support-pattern-in-inline-edge-function-config
branch
from
227d8c9
to
903e6cc
Compare
JGAntunes
approved these changes
Jul 3, 2024
eduardoboucas
approved these changes
Jul 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
This allows setting
pattern(andexcludedPattern) in inline config for edge functions which might result in not needing to use separate manifest json file. Primary motivation is to simplify usage of Frameworks API (but not limited to it as this allows usingpatternalso in user defined function configs as well as good old.netlify/edge-functions)For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)