Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: leverage the internal config inside the getEnv as well #5769

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

lukasholzer
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

leverage the internal config inside the getEnv as well, the internal config is set through the cached config by the CLI

Needed for: https://linear.app/netlify/issue/CT-738/cli-should-use-framework-detection-and-install-runtime-for-build-and

This is needed in addition to: #5761


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

the internal config is set through the cached config by the CLI
@lukasholzer lukasholzer requested review from a team as code owners July 12, 2024 14:16
packages/config/src/env/main.ts Outdated Show resolved Hide resolved
@lukasholzer lukasholzer enabled auto-merge (squash) July 12, 2024 14:38
@lukasholzer lukasholzer merged commit 5e6ec8a into main Jul 12, 2024
37 checks passed
@lukasholzer lukasholzer deleted the fix/use-env-from-cached-config-inside-get-env branch July 12, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants