feat(config): return account id from config in offline mode #5810
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes FRP-1269 - https://linear.app/netlify/issue/FRP-1269/information-request-is-the-account-id-available-for-build-plugins.
By default, when running in offline/buildbot mode netlify/config doesn't issue any requests to the get site endpoint. This means that until now the resulting
@netlify/config
didn't have anything else besides thesiteId
under thesiteInfo
object. This change will make sure we also return theaccount_id
in accordance with thegetSite
operation - https://open-api.netlify.com/#tag/site/operation/getSite - if@netlify/config
has been provided with anaccount-id
through cli param.The most important outcome of this change is that it will allow plugins to access
account_id
at execution time in buildbot through thenetlifyConfig
object:build/packages/build/src/plugins/child/run.js
Line 29 in d5ef407
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)