Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): return account id from config in offline mode #5810

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

JGAntunes
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes FRP-1269 - https://linear.app/netlify/issue/FRP-1269/information-request-is-the-account-id-available-for-build-plugins.

By default, when running in offline/buildbot mode netlify/config doesn't issue any requests to the get site endpoint. This means that until now the resulting @netlify/config didn't have anything else besides the siteId under the siteInfo object. This change will make sure we also return the account_id in accordance with the getSite operation - https://open-api.netlify.com/#tag/site/operation/getSite - if @netlify/config has been provided with an account-id through cli param.

The most important outcome of this change is that it will allow plugins to access account_id at execution time in buildbot through the netlifyConfig object:


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@JGAntunes JGAntunes self-assigned this Aug 21, 2024
@JGAntunes JGAntunes requested review from a team as code owners August 21, 2024 15:23
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

Copy link
Contributor

@lukasholzer lukasholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JGAntunes JGAntunes merged commit e82859d into main Aug 21, 2024
37 checks passed
@JGAntunes JGAntunes deleted the feat/account-id-to-plugins branch August 21, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants