fix: send response body with status text for invalid methods

netlify · Jan 3, 2023 · 00f6ef2 · 00f6ef2
1 parent c5eac34
commit 00f6ef2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/commands/dev/dev.mjs b/src/commands/dev/dev.mjs
@@ -71,7 +71,7 @@ const startStaticServer = async ({ settings }) => {
   server.addHook('onRequest', (req, reply, done) => {
     const validMethods = ['GET', 'HEAD']
     if (!validMethods.includes(req.method)) {
-      reply.code(405).send()
+      reply.code(405).send('Method Not Allowed')
     }
     done()
   })

diff --git a/tests/integration/500.command.dev.test.cjs b/tests/integration/500.command.dev.test.cjs
@@ -166,7 +166,7 @@ test('should handle form submission with a background function', async (t) => {
   })
 })
 
-test('should not handle form submission when content type is `text/plain`', async (t) => {
+test.only('should not handle form submission when content type is `text/plain`', async (t) => {
   await withSiteBuilder('site-with-form-text-plain', async (builder) => {
     builder
       .withContentFile({
@@ -197,6 +197,7 @@ test('should not handle form submission when content type is `text/plain`', asyn
           },
         })
         .catch((error) => error.response)
+      t.is(response.statusCode, 405)
       t.is(response.body, 'Method Not Allowed')
     })
   })