Skip to content

Commit

Permalink
fix: update graph dep to handle unions and interfaces (#4922)
Browse files Browse the repository at this point in the history
* fix: update graph dep to handle unions and interfaces

* fix: remove debug file

* fix: update dep
  • Loading branch information
sgrove authored Aug 10, 2022
1 parent df0c767 commit 0290c45
Show file tree
Hide file tree
Showing 5 changed files with 31 additions and 27 deletions.
14 changes: 7 additions & 7 deletions npm-shrinkwrap.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@
"multiparty": "^4.2.1",
"netlify": "^12.0.0",
"netlify-headers-parser": "^6.0.2",
"netlify-onegraph-internal": "0.7.0",
"netlify-onegraph-internal": "0.8.1",
"netlify-redirect-parser": "^13.0.5",
"netlify-redirector": "^0.2.1",
"node-fetch": "^2.6.0",
Expand Down
6 changes: 5 additions & 1 deletion src/lib/one-graph/cli-netlify-graph.js
Original file line number Diff line number Diff line change
Expand Up @@ -874,7 +874,11 @@ let lastWarnedFailedCodegenModule
*/
const dynamicallyLoadCodegenModule = async ({ config, cwd }) => {
const basePath = cwd || process.cwd()
const importPath = config.graph.codeGenerator
const importPath = config.graph && config.graph.codeGenerator

if (!importPath) {
return
}

// We currently include some default code generators for the most common framework
// use-cases. We still require it to be explicitly configured in netlify.toml,
Expand Down
36 changes: 18 additions & 18 deletions tests/integration/snapshots/530.graph-codegen.test.js.md
Original file line number Diff line number Diff line change
Expand Up @@ -1382,7 +1382,7 @@ Generated by [AVA](https://avajs.dev).
* Metadata and logged-in state for all OneGraph services␊
*/␊
serviceMetadata: {␊
loggedInServices: Array<LoggedInServicesFragment>;␊
loggedInServices: Array<LoggedInServicesFragment >;␊
};␊
};␊
};␊
Expand Down Expand Up @@ -1633,7 +1633,7 @@ Generated by [AVA](https://avajs.dev).
loggedInServices: Array<LoggedInServicesFragment & {␊
usedTestFlow: boolean;␊
friendlyServiceName: string;␊
}>;␊
} >;␊
};␊
};␊
};␊
Expand Down Expand Up @@ -1777,7 +1777,7 @@ Generated by [AVA](https://avajs.dev).
* Metadata and logged-in state for all OneGraph services␊
*/␊
serviceMetadata: {␊
loggedInServices: Array<LoggedInServicesFragment>;␊
loggedInServices: Array<LoggedInServicesFragment >;␊
};␊
};␊
};␊
Expand Down Expand Up @@ -2181,7 +2181,7 @@ Generated by [AVA](https://avajs.dev).
data: {␊
oneGraph: {␊
addCORSOriginToApp: {␊
app: AppCORSOriginFragment;␊
app: AppCORSOriginFragment ;␊
};␊
};␊
};␊
Expand Down Expand Up @@ -2211,7 +2211,7 @@ Generated by [AVA](https://avajs.dev).
data: {␊
oneGraph: {␊
removeCORSOriginFromApp: {␊
app: AppCORSOriginFragment;␊
app: AppCORSOriginFragment ;␊
};␊
};␊
};␊
Expand Down Expand Up @@ -2243,7 +2243,7 @@ Generated by [AVA](https://avajs.dev).
*/␊
data: {␊
oneGraph: {␊
app: AppCORSOriginFragment;␊
app: AppCORSOriginFragment ;␊
};␊
};␊
/**␊
Expand Down Expand Up @@ -3802,7 +3802,7 @@ Generated by [AVA](https://avajs.dev).
* Metadata and logged-in state for all OneGraph services␊
*/␊
serviceMetadata: {␊
loggedInServices: Array<LoggedInServicesFragment>;␊
loggedInServices: Array<LoggedInServicesFragment >;␊
};␊
};␊
};␊
Expand Down Expand Up @@ -4053,7 +4053,7 @@ Generated by [AVA](https://avajs.dev).
loggedInServices: Array<LoggedInServicesFragment & {␊
usedTestFlow: boolean;␊
friendlyServiceName: string;␊
}>;␊
} >;␊
};␊
};␊
};␊
Expand Down Expand Up @@ -4197,7 +4197,7 @@ Generated by [AVA](https://avajs.dev).
* Metadata and logged-in state for all OneGraph services␊
*/␊
serviceMetadata: {␊
loggedInServices: Array<LoggedInServicesFragment>;␊
loggedInServices: Array<LoggedInServicesFragment >;␊
};␊
};␊
};␊
Expand Down Expand Up @@ -4601,7 +4601,7 @@ Generated by [AVA](https://avajs.dev).
data: {␊
oneGraph: {␊
addCORSOriginToApp: {␊
app: AppCORSOriginFragment;␊
app: AppCORSOriginFragment ;␊
};␊
};␊
};␊
Expand Down Expand Up @@ -4631,7 +4631,7 @@ Generated by [AVA](https://avajs.dev).
data: {␊
oneGraph: {␊
removeCORSOriginFromApp: {␊
app: AppCORSOriginFragment;␊
app: AppCORSOriginFragment ;␊
};␊
};␊
};␊
Expand Down Expand Up @@ -4663,7 +4663,7 @@ Generated by [AVA](https://avajs.dev).
*/␊
data: {␊
oneGraph: {␊
app: AppCORSOriginFragment;␊
app: AppCORSOriginFragment ;␊
};␊
};␊
/**␊
Expand Down Expand Up @@ -6222,7 +6222,7 @@ Generated by [AVA](https://avajs.dev).
* Metadata and logged-in state for all OneGraph services␊
*/␊
serviceMetadata: {␊
loggedInServices: Array<LoggedInServicesFragment>;␊
loggedInServices: Array<LoggedInServicesFragment >;␊
};␊
};␊
};␊
Expand Down Expand Up @@ -6473,7 +6473,7 @@ Generated by [AVA](https://avajs.dev).
loggedInServices: Array<LoggedInServicesFragment & {␊
usedTestFlow: boolean;␊
friendlyServiceName: string;␊
}>;␊
} >;␊
};␊
};␊
};␊
Expand Down Expand Up @@ -6617,7 +6617,7 @@ Generated by [AVA](https://avajs.dev).
* Metadata and logged-in state for all OneGraph services␊
*/␊
serviceMetadata: {␊
loggedInServices: Array<LoggedInServicesFragment>;␊
loggedInServices: Array<LoggedInServicesFragment >;␊
};␊
};␊
};␊
Expand Down Expand Up @@ -7021,7 +7021,7 @@ Generated by [AVA](https://avajs.dev).
data: {␊
oneGraph: {␊
addCORSOriginToApp: {␊
app: AppCORSOriginFragment;␊
app: AppCORSOriginFragment ;␊
};␊
};␊
};␊
Expand Down Expand Up @@ -7051,7 +7051,7 @@ Generated by [AVA](https://avajs.dev).
data: {␊
oneGraph: {␊
removeCORSOriginFromApp: {␊
app: AppCORSOriginFragment;␊
app: AppCORSOriginFragment ;␊
};␊
};␊
};␊
Expand Down Expand Up @@ -7083,7 +7083,7 @@ Generated by [AVA](https://avajs.dev).
*/␊
data: {␊
oneGraph: {␊
app: AppCORSOriginFragment;␊
app: AppCORSOriginFragment ;␊
};␊
};␊
/**␊
Expand Down
Binary file modified tests/integration/snapshots/530.graph-codegen.test.js.snap
Binary file not shown.

1 comment on commit 0290c45

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📊 Benchmark results

Package size: 228 MB

Please sign in to comment.