Add func-names ESLint rule (#1420)

.eslintrc.js

@@ -26,6 +26,7 @@ module.exports = {
     'default-case': 2,
     'default-case-last': 2,
     'func-name-matching': [2, { considerPropertyDescriptor: true }],
+    'func-names': [2, 'as-needed'],
     'max-classes-per-file': 2,
     'max-params': [2, { max: 4 }],
     'multiline-comment-style': [2, 'separate-lines'],

site/watch.js

@@ -9,21 +9,21 @@ const { ensureFilePathAsync, removeRecursiveAsync } = require('./fs')
 const watcher = sane(config.docs.srcPath, { glob: ['**/*.md'] })
 
 /* Watch Files */
-watcher.on('ready', function () {
+watcher.on('ready', function onReady() {
   console.log(`Watching ${config.docs.srcPath} files for changes`)
 })
 
-watcher.on('change', async function (filepath) {
+watcher.on('change', async function onChange(filepath) {
   console.log('file changed', filepath)
   await syncFile(filepath)
 })
 
-watcher.on('add', async function (filepath) {
+watcher.on('add', async function onAdd(filepath) {
   console.log('file added')
   await syncFile(filepath)
 })
 
-watcher.on('delete', async function (filepath) {
+watcher.on('delete', async function onDelete(filepath) {
   console.log('file deleted', filepath)
   await deleteFile(filepath)
   console.log('File deletion complete')

src/commands/dev/index.js

@@ -30,7 +30,7 @@ async function startFrameworkServer({ settings, log, exit }) {
     })
 
     await new Promise((resolve) => {
-      server.start(function () {
+      server.start(function onListening() {
         log(`\n${NETLIFYDEVLOG} Server listening to`, settings.frameworkPort)
         resolve()
       })

src/detectors/README.md

@@ -35,7 +35,7 @@ requires a global install: https://github.com/GitbookIO/gitbook/blob/master/docs
 
 ```js
 const { hasRequiredDeps, hasRequiredFiles, getYarnOrNPMCommand, scanScripts } = require('./utils/jsdetect')
-module.exports = function () {
+module.exports = function detector() {
   // REQUIRED FILES
   if (!hasRequiredFiles(['README.md', 'SUMMARY.md'])) return false
   // // REQUIRED DEPS

src/detectors/angular.js

@@ -1,6 +1,6 @@
 const { hasRequiredDeps, hasRequiredFiles, getYarnOrNPMCommand, scanScripts } = require('./utils/jsdetect')
 
-module.exports = function () {
+module.exports = function detector() {
   // REQUIRED FILES
   if (!hasRequiredFiles(['package.json'])) return false
   if (!hasRequiredFiles(['angular.json'])) return false

src/detectors/brunch.js

@@ -1,5 +1,5 @@
 const { hasRequiredDeps, hasRequiredFiles, getYarnOrNPMCommand, scanScripts } = require('./utils/jsdetect')
-module.exports = function () {
+module.exports = function detector() {
   // REQUIRED FILES
   if (!hasRequiredFiles(['package.json', 'brunch-config.js'])) return false
   // REQUIRED DEPS

src/detectors/create-react-app.js

@@ -3,7 +3,7 @@ const { hasRequiredDeps, hasRequiredFiles, getYarnOrNPMCommand, scanScripts } =
 //
 // detection logic - artificial intelligence!
 //
-module.exports = function () {
+module.exports = function detector() {
   // REQUIRED FILES
   if (!hasRequiredFiles(['package.json'])) return false
   // REQUIRED DEPS

src/detectors/docusaurus.js

@@ -1,5 +1,5 @@
 const { hasRequiredDeps, hasRequiredFiles, getYarnOrNPMCommand, scanScripts } = require('./utils/jsdetect')
-module.exports = function () {
+module.exports = function detector() {
   // REQUIRED FILES
   if (!hasRequiredFiles(['package.json'])) return false
 

src/detectors/eleventy.js

@@ -1,6 +1,6 @@
 const { hasRequiredDeps, hasRequiredFiles } = require('./utils/jsdetect')
 
-module.exports = function () {
+module.exports = function detector() {
   // REQUIRED FILES
   if (
     !hasRequiredFiles(['package.json', '.eleventy.js']) &&

src/detectors/ember.js

@@ -1,6 +1,6 @@
 const { hasRequiredDeps, hasRequiredFiles, getYarnOrNPMCommand, scanScripts } = require('./utils/jsdetect')
 
-module.exports = function () {
+module.exports = function detector() {
   // REQUIRED FILES
   if (!hasRequiredFiles(['package.json'])) return false
   if (!hasRequiredFiles(['ember-cli-build.js'])) return false

src/detectors/expo.js

@@ -1,5 +1,5 @@
 const { hasRequiredDeps, hasRequiredFiles, getYarnOrNPMCommand, scanScripts } = require('./utils/jsdetect')
-module.exports = function () {
+module.exports = function detector() {
   // REQUIRED FILES
   if (!hasRequiredFiles(['package.json', 'app.json'])) return false
   // REQUIRED DEPS

src/detectors/gatsby.js

@@ -1,5 +1,5 @@
 const { hasRequiredDeps, hasRequiredFiles, getYarnOrNPMCommand, scanScripts } = require('./utils/jsdetect')
-module.exports = function () {
+module.exports = function detector() {
   // REQUIRED FILES
   if (!hasRequiredFiles(['package.json', 'gatsby-config.js'])) return false
   // REQUIRED DEPS

src/detectors/gridsome.js

@@ -1,5 +1,5 @@
 const { hasRequiredDeps, hasRequiredFiles, getYarnOrNPMCommand, scanScripts } = require('./utils/jsdetect')
-module.exports = function () {
+module.exports = function detector() {
   // REQUIRED FILES
   if (!hasRequiredFiles(['package.json', 'gridsome.config.js'])) return false
   // REQUIRED DEPS

src/detectors/hexo.js

@@ -1,5 +1,5 @@
 const { hasRequiredDeps, hasRequiredFiles, getYarnOrNPMCommand, scanScripts } = require('./utils/jsdetect')
-module.exports = function () {
+module.exports = function detector() {
   // REQUIRED FILES
   if (!hasRequiredFiles(['package.json', '_config.yml'])) return false
   // REQUIRED DEPS

src/detectors/hugo.js

@@ -1,6 +1,6 @@
 const { existsSync } = require('fs')
 
-module.exports = function () {
+module.exports = function detector() {
   if (!existsSync('config.toml') && !existsSync('config.yaml')) {
     return false
   }

src/detectors/jekyll.js

@@ -1,6 +1,6 @@
 const { existsSync } = require('fs')
 
-module.exports = function () {
+module.exports = function detector() {
   if (!existsSync('_config.yml')) {
     return false
   }

src/detectors/middleman.js

@@ -1,6 +1,6 @@
 const { existsSync } = require('fs')
 
-module.exports = function () {
+module.exports = function detector() {
   if (!existsSync('config.rb')) {
     return false
   }

src/detectors/next.js

@@ -1,5 +1,5 @@
 const { hasRequiredDeps, hasRequiredFiles, getYarnOrNPMCommand, scanScripts } = require('./utils/jsdetect')
-module.exports = function () {
+module.exports = function detector() {
   // REQUIRED FILES
   if (!hasRequiredFiles(['package.json'])) return false
   // REQUIRED DEPS

src/detectors/nuxt.js

@@ -1,6 +1,6 @@
 const { hasRequiredDeps, hasRequiredFiles, getYarnOrNPMCommand, scanScripts } = require('./utils/jsdetect')
 
-module.exports = function () {
+module.exports = function detector() {
   // REQUIRED FILES
   if (!hasRequiredFiles(['package.json'])) return false
   // REQUIRED DEPS

src/detectors/parcel.js

@@ -1,6 +1,6 @@
 const { hasRequiredDeps, hasRequiredFiles, getYarnOrNPMCommand, scanScripts } = require('./utils/jsdetect')
 
-module.exports = function () {
+module.exports = function detector() {
   /* REQUIRED FILES */
   if (!hasRequiredFiles(['package.json'])) return false
 

src/detectors/phenomic.js

@@ -1,5 +1,5 @@
 const { hasRequiredDeps, hasRequiredFiles, getYarnOrNPMCommand, scanScripts } = require('./utils/jsdetect')
-module.exports = function () {
+module.exports = function detector() {
   // REQUIRED FILES
   if (!hasRequiredFiles(['package.json'])) return false
   // REQUIRED DEPS

src/detectors/quasar-v0.17.js

@@ -1,6 +1,6 @@
 const { hasRequiredDeps, hasRequiredFiles, getYarnOrNPMCommand, scanScripts } = require('./utils/jsdetect')
 
-module.exports = function () {
+module.exports = function detector() {
   // REQUIRED FILES
   if (!hasRequiredFiles(['package.json'])) return false
   // REQUIRED DEPS

src/detectors/quasar.js

@@ -1,6 +1,6 @@
 const { hasRequiredDeps, hasRequiredFiles, getYarnOrNPMCommand, scanScripts } = require('./utils/jsdetect')
 
-module.exports = function () {
+module.exports = function detector() {
   // REQUIRED FILES
   if (!hasRequiredFiles(['package.json'])) return false
   // REQUIRED DEPS

src/detectors/react-static.js

@@ -1,5 +1,5 @@
 const { hasRequiredDeps, hasRequiredFiles, getYarnOrNPMCommand, scanScripts } = require('./utils/jsdetect')
-module.exports = function () {
+module.exports = function detector() {
   // REQUIRED FILES
   if (!hasRequiredFiles(['package.json', 'static.config.js'])) return false
   // REQUIRED DEPS

src/detectors/sapper.js

@@ -1,6 +1,6 @@
 const { hasRequiredDeps, hasRequiredFiles, getYarnOrNPMCommand, scanScripts } = require('./utils/jsdetect')
 
-module.exports = function () {
+module.exports = function detector() {
   // REQUIRED FILES
   if (!hasRequiredFiles(['package.json'])) return false
   // REQUIRED DEPS

src/detectors/stencil.js

@@ -3,7 +3,7 @@ const { hasRequiredDeps, hasRequiredFiles, getYarnOrNPMCommand, scanScripts } =
 //
 // detection logic - artificial intelligence!
 //
-module.exports = function () {
+module.exports = function detector() {
   // REQUIRED FILES
   if (!hasRequiredFiles(['package.json', 'stencil.config.ts'])) return false
   // REQUIRED DEPS

src/detectors/svelte.js

@@ -1,6 +1,6 @@
 const { hasRequiredDeps, hasRequiredFiles, getYarnOrNPMCommand, scanScripts } = require('./utils/jsdetect')
 
-module.exports = function () {
+module.exports = function detector() {
   // REQUIRED FILES
   if (!hasRequiredFiles(['package.json'])) return false
   // REQUIRED DEPS

src/detectors/vue.js

@@ -1,6 +1,6 @@
 const { hasRequiredDeps, hasRequiredFiles, getYarnOrNPMCommand, scanScripts } = require('./utils/jsdetect')
 
-module.exports = function () {
+module.exports = function detector() {
   // REQUIRED FILES
   if (!hasRequiredFiles(['package.json'])) return false
   // REQUIRED DEPS

src/detectors/vuepress.js

@@ -1,6 +1,6 @@
 const { hasRequiredDeps, hasRequiredFiles, getYarnOrNPMCommand, scanScripts } = require('./utils/jsdetect')
 
-module.exports = function () {
+module.exports = function detector() {
   // REQUIRED FILES
   if (!hasRequiredFiles(['package.json'])) return false
   // REQUIRED DEPS

src/function-builder-detectors/netlify-lambda.js

@@ -1,7 +1,7 @@
 const { existsSync, readFileSync } = require('fs')
 const execa = require('execa')
 
-module.exports = function () {
+module.exports = function handler() {
   if (!existsSync('package.json')) {
     return false
   }

src/functions-templates/js/apollo-graphql-rest/apollo-graphql-rest.js

@@ -62,4 +62,6 @@ const server = new ApolloServer({
   }),
 })
 
-exports.handler = server.createHandler()
+const handler = server.createHandler()
+
+module.exports = { handler }

src/functions-templates/js/apollo-graphql/apollo-graphql.js

@@ -41,4 +41,6 @@ const server = new ApolloServer({
   resolvers,
 })
 
-exports.handler = server.createHandler()
+const handler = server.createHandler()
+
+module.exports = { handler }

src/functions-templates/js/auth-fetch/auth-fetch.js

@@ -1,7 +1,7 @@
 // for a full working demo of Netlify Identity + Functions, see https://netlify-gotrue-in-react.netlify.com/
 
 const fetch = require('node-fetch')
-exports.handler = async function (event, context) {
+const handler = async function (event, context) {
   if (!context.clientContext && !context.clientContext.identity) {
     return {
       statusCode: 500,
@@ -31,3 +31,5 @@ exports.handler = async function (event, context) {
     }
   }
 }
+
+module.exports = { handler }

src/functions-templates/js/create-user/create-user.js

@@ -1,6 +1,6 @@
 const fetch = require('node-fetch')
 
-exports.handler = async (event, context) => {
+const handler = async (event, context) => {
   if (event.httpMethod !== 'POST') return { statusCode: 400, body: 'Must POST to this function' }
 
   // send account information along with the POST
@@ -32,3 +32,5 @@ exports.handler = async (event, context) => {
     body: 'success!',
   }
 }
+
+module.exports = { handler }

src/functions-templates/js/fauna-crud/create.js

@@ -7,7 +7,7 @@ const client = new faunadb.Client({
 })
 
 /* export our lambda function as named "handler" export */
-exports.handler = async (event) => {
+const handler = async (event) => {
   /* parse the string body into a useable JS object */
   const data = JSON.parse(event.body)
   console.log('Function `create` invoked', data)
@@ -34,3 +34,5 @@ exports.handler = async (event) => {
       }
     })
 }
+
+module.exports = { handler }

src/functions-templates/js/fauna-crud/delete.js

@@ -6,7 +6,7 @@ const client = new faunadb.Client({
   secret: process.env.FAUNADB_SERVER_SECRET,
 })
 
-exports.handler = async (event) => {
+const handler = async (event) => {
   const { id } = event
   console.log(`Function 'delete' invoked. delete id: ${id}`)
   return client
@@ -26,3 +26,5 @@ exports.handler = async (event) => {
       }
     })
 }
+
+module.exports = { handler }

src/functions-templates/js/fauna-crud/fauna-crud.js

@@ -1,4 +1,4 @@
-exports.handler = async (event, context) => {
+const handler = async (event, context) => {
   const path = event.path.replace(/\.netlify\/functions\/[^/]+/, '')
   const segments = path.split('/').filter((e) => e)
 
@@ -53,3 +53,5 @@ exports.handler = async (event, context) => {
       }
   }
 }
+
+module.exports = { handler }

src/functions-templates/js/fauna-crud/read-all.js

@@ -6,7 +6,7 @@ const client = new faunadb.Client({
   secret: process.env.FAUNADB_SERVER_SECRET,
 })
 
-exports.handler = async () => {
+const handler = async () => {
   console.log('Function `read-all` invoked')
   return client
     .query(q.Paginate(q.Match(q.Ref('indexes/all_items'))))
@@ -32,3 +32,5 @@ exports.handler = async () => {
       }
     })
 }
+
+module.exports = { handler }

src/functions-templates/js/fauna-crud/read.js

@@ -6,7 +6,7 @@ const client = new faunadb.Client({
   secret: process.env.FAUNADB_SERVER_SECRET,
 })
 
-exports.handler = async (event) => {
+const handler = async (event) => {
   const { id } = event
   console.log(`Function 'read' invoked. Read id: ${id}`)
   return client
@@ -26,3 +26,5 @@ exports.handler = async (event) => {
       }
     })
 }
+
+module.exports = { handler }

src/functions-templates/js/fauna-crud/update.js

@@ -6,7 +6,7 @@ const client = new faunadb.Client({
   secret: process.env.FAUNADB_SERVER_SECRET,
 })
 
-exports.handler = async (event) => {
+const handler = async (event) => {
   const data = JSON.parse(event.body)
   const { id } = event
   console.log(`Function 'update' invoked. update id: ${id}`)
@@ -27,3 +27,5 @@ exports.handler = async (event) => {
       }
     })
 }
+
+module.exports = { handler }