chore(lint): add default-param-last ESLint rule

netlify · Oct 20, 2020 · 5e17bcc · 5e17bcc
1 parent 68e83b1
commit 5e17bcc
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -26,6 +26,7 @@ module.exports = {
     // Those ESLint rules are not enabled by Prettier, ESLint recommended rules
     // nor standard JavaScript. However, they are still useful
     'array-callback-return': [2, { allowImplicit: true, checkForEach: true }],
+    'default-param-last': 2,
     'func-name-matching': [2, { considerPropertyDescriptor: true }],
     'multiline-comment-style': [2, 'separate-lines'],
     'no-else-return': [2, { allowElseIf: false }],

diff --git a/src/commands/functions/create.js b/src/commands/functions/create.js
@@ -354,7 +354,7 @@ async function createFunctionAddon({ api, addons, siteId, addonName, siteData, l
   }
 }
 
-async function installAddons(context, functionAddons = [], fnPath) {
+async function installAddons(context, functionAddons, fnPath) {
   if (functionAddons.length === 0) {
     return
   }

diff --git a/src/utils/proxy.js b/src/utils/proxy.js
@@ -296,7 +296,7 @@ function initializeProxy(port, distDir, projectDir) {
   return handlers
 }
 
-async function startProxy(settings = {}, addonUrls, configPath, projectDir) {
+async function startProxy(settings, addonUrls, configPath, projectDir) {
   const functionsServer = settings.functionsPort ? `http://localhost:${settings.functionsPort}` : null
 
   const proxy = initializeProxy(settings.frameworkPort, settings.dist, projectDir)
-Original file line number
+Diff line change
@@ Expand Up @@
       }
     }
-    async function installAddons(context, functionAddons = [], fnPath) {
+    async function installAddons(context, functionAddons, fnPath) {
       if (functionAddons.length === 0) {
         return
       }
@@ Expand Down @@