Skip to content

Commit

Permalink
fix: remove dependency is-plain-obj (#5702)
Browse files Browse the repository at this point in the history
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
  • Loading branch information
danez and kodiakhq[bot] authored May 15, 2023
1 parent 769e345 commit 8349de4
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 4 deletions.
1 change: 0 additions & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@
"inquirer": "6.5.2",
"inquirer-autocomplete-prompt": "1.4.0",
"is-docker": "3.0.0",
"is-plain-obj": "4.1.0",
"is-wsl": "2.2.0",
"isexe": "2.0.0",
"jsonwebtoken": "9.0.0",
Expand Down
3 changes: 1 addition & 2 deletions src/utils/detect-server-settings.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import { NodeFS } from '@netlify/build-info/node'
import { getFramework, listFrameworks } from '@netlify/framework-info'
import fuzzy from 'fuzzy'
import getPort from 'get-port'
import isPlainObject from 'is-plain-obj'

import { NETLIFYDEVWARN, chalk, log } from './command-helpers.mjs'
import { acquirePort } from './dev.mjs'
Expand All @@ -21,7 +20,7 @@ const formatProperty = (str) => chalk.magenta(`'${str}'`)
const formatValue = (str) => chalk.green(`'${str}'`)

const readHttpsSettings = async (options) => {
if (!isPlainObject(options)) {
if (typeof options !== 'object' || !options.keyFile || !options.certFile) {
throw new TypeError(
`https options should be an object with ${formatProperty('keyFile')} and ${formatProperty(
'certFile',
Expand Down

1 comment on commit 8349de4

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📊 Benchmark results

  • Package size: 233 MB

Please sign in to comment.