chore(lint): add default-case ESLint rule (#1418)

.eslintrc.js

@@ -19,6 +19,7 @@ module.exports = {
     // Those ESLint rules are not enabled by Prettier, ESLint recommended rules
     // nor standard JavaScript. However, they are still useful
     'array-callback-return': [2, { allowImplicit: true, checkForEach: true }],
+    'default-case': 2,
     'func-name-matching': [2, { considerPropertyDescriptor: true }],
     'max-params': [2, { max: 4 }],
     'multiline-comment-style': [2, 'separate-lines'],

src/commands/init.js

@@ -78,18 +78,11 @@ This will allow for Netlify Continuous deployment to build branch & PR previews.
 
 For more details on Netlify CI checkout the docs: http://bit.ly/2N0Jhy5
 `)
-      let message
-      switch (repo.error) {
-        case "Couldn't find origin url": {
-          message = `Unable to find a remote origin URL. Please add a git remote.
+      if (repo.error === "Couldn't find origin url") {
+        console.log(`Unable to find a remote origin URL. Please add a git remote.
 
 git remote add origin https://github.com/YourUserName/RepoName.git
-`
-          break
-        }
-      }
-      if (message) {
-        console.log(message)
+`)
       }
 
       const NEW_SITE_NO_GIT = 'Yes, create and deploy site manually'

src/functions-templates/js/fauna-crud/fauna-crud.js

@@ -46,9 +46,10 @@ exports.handler = async (event, context) => {
         statusCode: 500,
         body: 'invalid segments in DELETE request, must be /.netlify/functions/fauna-crud/123456',
       }
-  }
-  return {
-    statusCode: 500,
-    body: 'unrecognized HTTP Method, must be one of GET/POST/PUT/DELETE',
+    default:
+      return {
+        statusCode: 500,
+        body: 'unrecognized HTTP Method, must be one of GET/POST/PUT/DELETE',
+      }
   }
 }

src/functions-templates/js/url-shortener/url-shortener.js

@@ -16,7 +16,7 @@ exports.handler = (event, context, callback) => {
     case 'DELETE':
       // your code here
       return
+    default:
+      return callback(new Error('unrecognized HTTP Method, must be one of GET/POST/PUT/DELETE'))
   }
-
-  return callback(new Error('unrecognized HTTP Method, must be one of GET/POST/PUT/DELETE'))
 }

src/utils/get-repo-data.js

@@ -48,17 +48,7 @@ async function getRepoData(remote) {
       repo_branch: repoData.branch,
       allowed_branches: [repoData.branch],
       host: remoteData.host,
-    }
-
-    switch (remoteData.host) {
-      case 'github.com': {
-        repo.provider = 'github'
-        break
-      }
-      case 'gitlab.com': {
-        repo.provider = 'gitlab'
-        break
-      }
+      provider: PROVIDERS[remoteData.host],
     }
   } catch (error) {
     // console.log('error', error)
@@ -70,4 +60,9 @@ async function getRepoData(remote) {
   return repo
 }
 
+const PROVIDERS = {
+  'github.com': 'github',
+  'gitlab.com': 'gitlab',
+}
+
 module.exports = getRepoData

src/utils/link/link-by-prompt.js

@@ -214,6 +214,8 @@ or run ${chalk.cyanBright('netlify sites:create')} to create a site.`)
       }
       break
     }
+    default:
+      return
   }
 
   if (!site) {