Connecting site by git remote url not working for private repos

[verythorough]

- Do you want to request a feature or report a bug?
bug

- What is the current behavior?
When running netlify link to connect a local repo to an existing site, you have the option to find the matching site using the current git remote url:

I've tested on several private and public repos now, and the public ones consistently work, and the private ones consistently fail to find a linked repo:

- If the current behavior is a bug, please provide the steps to reproduce.
In a local clone of a private repo, run netlify link, and choose the default option to find the site by remote.

- What is the expected behavior?
It finds the site(s) in all cases. :)

- Please mention your node.js, and operating system version.

Tried on multiple machines:
netlify-cli/2.8.0 win32-x64 node-v10.15.0
netlify-cli/2.8.0 darwin-x64 node-v10.15.0

[DavidWells]

The API call needs ?filter=all. https://api.netlify.com/api/v1/sites?filter=all

Needs to get updated here:

cli/src/utils/link/link-by-prompt.js

Line 60 in f9bc817

const sites = await api.listSites()

@bcomnes does https://github.com/netlify/js-client support query params like this?

[bcomnes]

@DavidWells any parameter listed in the operations over at https://open-api.netlify.com/#/default/listSites will work if you pass them in as an object to the call

const sites = await api.listSites({
  name: 'whatever',
  filter: 'foo bar'
})

[DavidWells]

Tried that here

cli/src/utils/link/link-by-prompt.js

Line 60 in f9bc817

const sites = await api.listSites()

const sites = await api.listSites({
   filter: 'all',
})

It pulls back more sites but not all if you have more than 100. Pagination params didn't seem to work

[bcomnes]

Yeah, still need to add netlify/js-client#39

[erezrokah]

filter: all was done in #500.
Keeping this open until we sort pagination