fix(command-link): retrieve all sites using pagination params #1899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
commented
Feb 17, 2021
| let sites | ||
| try { | ||
| sites = await api.listSites({ filter: 'all' }) | ||
| sites = await listSites({ api, options: { maxPages: 1, filter: 'all' } }) |
There was a problem hiding this comment.
Limit to 1 page of results since the option here is Fetching recently updated sites
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Fixes #1898
Doesn't fix #258 since that issue is now related to strict SAML support in the CLI.
- Test plan
Tested manually
$ ntl sites:list --json | jq length $ 226- Description for the changelog
Paginate on all sites when calling
listSites- A picture of a cute animal (not mandatory but encouraged)
