-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correctly support multiValueHeaders in rust functions during development #4632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
changed the title
fix: correctly support multiValueHeaders in go functions during development
fix: correctly support multiValueHeaders in rust functions during development
May 27, 2022
…elopment `multiValueHeaders` was simply not forwarded from the response of the rust function
danez
force-pushed
the
rust-functions-multivalueheader
branch
from
May 27, 2022 09:38
5f646ad
to
ee9a51f
Compare
📊 Benchmark resultsComparing with a8bfc66 Package size: 287 MB⬇️ 0.00% decrease vs. a8bfc66
Legend
|
eduardoboucas
approved these changes
May 29, 2022
This was referenced May 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: functions
automerge
Add to Kodiak auto merge queue
type: bug
code to address defects in shipped code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
multiValueHeaders
was simply not forwarded from the response of the rust functionThis is similar to #4618 but for rust.
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)