-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correctly support multiValueHeaders
in go functions during development
#4618
Conversation
…elopment `multiValueHeaders` was simply not forwarded from the response of the go function
📊 Benchmark resultsComparing with 441d7ff Package size: 287 MB(no change)
Legend
|
🤔 The automation doesn't seem to be sure if I am a contributor 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Also, to your question:
Side note:
rust
functions have the same problem, but I did not want to fix this in one PR. Should I apply this fix also to rust?
Yes, please! 🙌🏻
Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Summary
Fixes #4575
multiValueHeaders
was simply not forwarded from the response of the go functionSide note:
rust
functions have the same problem, but I did not want to fix this in one PR. Should I apply this fix also to rust?For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.