feat: add graph:init command #4711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgrove
added
the
type: feature
📊 Benchmark resultsComparing with d10b135 Package size: 226 MB⬇️ 0.00% decrease vs. d10b135 Legend
|
anmonteiro
reviewed
Jun 17, 2022
| error(`Unable to create Netlify Graph persist query token: ${JSON.stringify(result.errors, null, 2)}`) | ||
| } | ||
|
|
||
| if (envChanged) { |
There was a problem hiding this comment.
This seems to always be true.
anmonteiro
previously approved these changes
Jun 17, 2022
anmonteiro
previously approved these changes
Jun 23, 2022
src/commands/graph/graph-init.js
Outdated
Comment on lines
21
to
27
| if (!siteId) { | ||
| error( | ||
| `No siteId defined, unable to start Netlify Graph. To enable, run ${chalk.yellow( | ||
| 'netlify init', | ||
| )} or ${chalk.yellow('netlify link')}`, | ||
| ) | ||
| } |
There was a problem hiding this comment.
[sand] It looks like we're using a slightly different error log with graph-edit. In the interest of consistency, we should probably make them the same.
Looks like we're not importing NETLIFYDEVERR from utils in graph-init. Would need that to make the two error logs more consistent.
| envChanged = true | ||
| newEnv.NETLIFY_GRAPH_PERSIST_QUERY_TOKEN = token | ||
| } else { | ||
| error(`Unable to create Netlify Graph persist query token: ${JSON.stringify(result.errors, null, 2)}`) |
There was a problem hiding this comment.
[pebble] This error message explains the "what", but not the "why" or "what now". With error messages, we try to describe what happened, why it happened, and, if at all possible, what the user can do about it.
The error message for no side id above is a good example. Is there any way we can can explain why the error happened and, perhaps, guide users in what they can do here?
There was a problem hiding this comment.
The errors we're printing should give us more information about what happened.
📊 Benchmark resultsComparing with 7203fe5 Package size: 230 MB(no change) Legend
|
Co-authored-by: Kyle Rollins <kyleblankrollins@gmail.com>
anmonteiro
approved these changes
Aug 1, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
graph:initto bootstrap all of the resources for a Netlify site to work with Netlify GraphFor us to review and ship your PR efficiently, please perform the following steps: