Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add graph:init command #4711
feat: add graph:init command #4711
Changes from 5 commits
8903759
63689f2
562fa1d
6bdfa2a
cd9425a
936ee9f
42227c1
20593f7
a247443
42a5935
5dbe07d
ded474e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[sand] It looks like we're using a slightly different error log with
graph-edit
. In the interest of consistency, we should probably make them the same.Looks like we're not importing
NETLIFYDEVERR
fromutils
ingraph-init
. Would need that to make the two error logs more consistent.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pebble] This error message explains the "what", but not the "why" or "what now". With error messages, we try to describe what happened, why it happened, and, if at all possible, what the user can do about it.
The error message for no side id above is a good example. Is there any way we can can explain why the error happened and, perhaps, guide users in what they can do here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The errors we're printing should give us more information about what happened.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to always be true.