Use isexe module
#1404
Merged
Use isexe module
#1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
the
type: chore
ehmicky
commented
Oct 15, 2020
src/lib/exec-fetcher.js
Outdated
| @@ -55,7 +34,7 @@ const isVersionOutdated = async ({ packageName, currentVersion }) => { | |||
| const shouldFetchLatestVersion = async ({ binPath, packageName, execName, execArgs, pattern, log }) => { | |||
| const execPath = path.join(binPath, getExecName({ execName })) | |||
|
|
|||
| const exists = await execExist(execPath) | |||
| const exists = await isExe(execPath) | |||
There was a problem hiding this comment.
isexe contains the code of execExist() not of isExe().
See source
ehmicky
force-pushed
the
chore/use-isexe
branch
from
99dfb5c to
5817e81
Compare
ehmicky
commented
Oct 15, 2020
| const stat = await fs.statAsync(binPath) | ||
| return stat.isFile() && isExe(stat.mode, stat.gid, stat.uid) | ||
| } catch (error) { | ||
| if (error.code === 'ENOENT') return false |
There was a problem hiding this comment.
This ENOENT check is the reason we use ignoreErrors: true. However, this will ignore all errors, not only ENOENT.
Without that option, only EACCESS is ignored.
erezrokah
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our code is a full copy/paste of the
isexedependency. I happened to remember it because I once looked at the code of this library, but our inlining was lacking attribution (this dependency license requires it).By using the module, we also benefit from: