-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(command-lm): merge netlify-lm-plugin to CLI #1489
Conversation
c94828f
to
ed0ecdc
Compare
Currently it is half-working.
(also looks like I got a lot of linting warning) |
Hi @keiko713, how do we want to move forward with this? |
thanks for the ping and sorry that I haven't touched this for more than one month...!!! I really would like to get back to this, but at the same time, I'm having hard time finding time for this. |
Should we can do that. I can also raise #483 internally to see if we can prioritize it. |
ed0ecdc
to
caa2936
Compare
current status:
TODOs
|
@erezrokah syncing up with some progress (also no rush, totally fine after 🎄 ):
Thanks! |
976ed87
to
4390b5e
Compare
@keiko713 Thank you so much for following up on this. For the failing tests, I had to run it on my Windows VM to get the error, see netlify/netlify-credential-helper#49 That made Looks like Linux is failing with |
b32349b
to
949741a
Compare
3d42b92
to
3559f57
Compare
cc @keiko713 tests are passing on Windows (Node.js 10 failure is unrelated). |
3559f57
to
20381cc
Compare
29771f2
to
c2e26b4
Compare
Co-authored-by: ehmicky <ehmicky@users.noreply.github.com>
Co-authored-by: ehmicky <ehmicky@users.noreply.github.com>
Co-authored-by: ehmicky <ehmicky@users.noreply.github.com>
Co-authored-by: ehmicky <ehmicky@users.noreply.github.com>
06a32ec
to
76fd489
Compare
- Summary
Closes #483
Closes #514
Closes netlify/netlify-lm-plugin#43
Closes netlify/netlify-credential-helper#46
netlify-lm-plugin is not maintained well currently, and using some deprecated dependency. This PR is to see if we can merge the plugin into the CLI to make it easy to maintain.
Also, I would love to retire the usage of old getAddons/createAddon, so that it'll better integrated with the development env var like
NETLIFY_API_URL
.- Test plan
Very much WIP.
This is also a great chance to add tests!!
- Description for the changelog
Merge netlify-lm-plugin (netlify lm command) to CLI
- A picture of a cute animal (not mandatory but encouraged)