Add logging for ignored env vars #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
added
the
type: feature
|
@erezrokah @ehmicky do you think we should merge this, or should we wait for the upcoming work related to netlify/build#2040? |
|
I think it's nice if we can break this separately. What do you think @erezrokah? |
|
I'm good with merging this. It will be easier to do netlify/build#2040 once we have these logs in place. |
erezrokah
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
This PR adds logging messages that flag to the user whenever an environment variable they've defined is overridden by another variable with the same name defined somewhere with a higher precedence.
Closes #1598.
- Test plan
In this example, I've defined
NETLIFY_TEST_VARin four places (.envfile,.env.developmentfile, team-level environment, and site-level environment) andTWITTER_SCREEN_NAMEin two (site-level environment and process level).- Description for the changelog
Log overridden environment variables
- A picture of a cute animal (not mandatory but encouraged)