Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use got instead of node-fetch #1733

Merged
merged 2 commits into from
Jan 14, 2021
Merged

test: use got instead of node-fetch #1733

merged 2 commits into from
Jan 14, 2021

Conversation

erezrokah
Copy link
Contributor

@erezrokah erezrokah commented Jan 14, 2021 •
edited
Loading

Replaces the usage of node-fetch to got in our tests.
This allows:

  1. Built in retries
  2. Built in timeouts

Related to #1703

@erezrokah erezrokah added the type: chore work needed to keep the product and development running smoothly label Jan 14, 2021
@erezrokah erezrokah requested a review from ehmicky January 14, 2021 15:54
@erezrokah erezrokah marked this pull request as ready for review January 14, 2021 15:54
@erezrokah erezrokah requested a review from a team as a code owner January 14, 2021 15:54
@erezrokah erezrokah merged commit 5fa9e3f into master Jan 14, 2021
@erezrokah erezrokah deleted the test/got_instead_of_fetch branch January 14, 2021 16:30
@MaxMood96 MaxMood96 mentioned this pull request May 7, 2024
Open
@svcsnyksanity svcsnyksanity mentioned this pull request May 8, 2024
Open
@CASABECI CASABECI mentioned this pull request May 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmicky ehmicky ehmicky approved these changes

Assignees
No one assigned
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erezrokah @ehmicky