test(command-dev): replace cra test with eleventy test #2171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: chore
erezrokah
commented
Apr 19, 2021
| @@ -1,4 +1,4 @@ | |||
| /force.html /test.html 200! | |||
| /something /otherthing.html | |||
| /force /test 200! | |||
There was a problem hiding this comment.
eleventy puts files in their own directories (e.g. test.html is copied to test/index.html)
📊 Benchmark resultsComparing with d74d294
|
erezrokah
commented
Apr 19, 2021
| t.true(response.includes('Web site created using create-react-app')) | ||
| }) | ||
|
|
||
| test('static/js/bundle.js', async (t) => { |
There was a problem hiding this comment.
This is removed as it is no longer required
erezrokah
commented
Apr 19, 2021
|
|
||
| const BUNDLE_MIN_LENGTH = 1e2 | ||
|
|
||
| test('static file under public/', async (t) => { |
There was a problem hiding this comment.
Also removed as it is no longer required
erezrokah
commented
Apr 19, 2021
| t.is(body, 'Redirecting to /otherthing.html') | ||
| }) | ||
|
|
||
| test('normal rewrite', async (t) => { |
There was a problem hiding this comment.
This one is skipped per #1242
erezrokah
commented
Apr 19, 2021
| }) | ||
|
|
||
| test('force rewrite', async (t) => { |
There was a problem hiding this comment.
This changed from getting force.html to force
erezrokah
commented
Apr 19, 2021
| }) | ||
|
|
||
| test('robots.txt', async (t) => { |
There was a problem hiding this comment.
Removed as no longer required
erezrokah
force-pushed
the
test/cra_test
branch
from
760bb00 to
e17985e
Compare
ehmicky
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Replaces the
create-react-appsite in our tests with aneleventysite.In order to run the
cratest wenpm cithe site's dependencies. This takes about 25 seconds on my machine.npm cion theeleventysite takes about 4 seconds.- Test plan
See test.
I had to
skipone test due to #1242 which I'll fix in a separate PR.Screenshots on the Windows CI machine:
- A picture of a cute animal (not mandatory but encouraged)
