-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): skip tests for release-please publish flow #3027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: chore
work needed to keep the product and development running smoothly
label
Jul 28, 2021
📊 Benchmark resultsComparing with 8b30015 Package size: 331 MB⬇️ 0.00% decrease vs. 8b30015
Legend
|
erezrokah
commented
Jul 28, 2021
@@ -30,6 +30,8 @@ jobs: | |||
- name: Install site dependencies | |||
run: npm run site:build:install | |||
if: ${{ steps.release.outputs.release_created }} | |||
- name: Install core dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved from the package.json
script so we can use run-s
and run-local
.
For local publishing it's expected to for the developer to already those available.
eduardoboucas
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automerge
Add to Kodiak auto merge queue
type: chore
work needed to keep the product and development running smoothly
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
This avoids re-running the tests before publishing on
release-please
workflows- Test plan
Existing tests
- A picture of a cute animal (not mandatory but encouraged)
🐪