feat: use netlify-headers-parser
#3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
the
type: feature
📊 Benchmark resultsComparing with fa064f1 Package size: 330 MB(no change) Legend
|
ehmicky
commented
Aug 16, 2021
| '/': { | ||
| 'X-Frame-Options': ['SAMEORIGIN'], | ||
| test('_headers: validate rules', async (t) => { | ||
| const rules = await parseHeaders({ headersFiles: [path.resolve(t.context.builder.directory, '_headers')] }) |
There was a problem hiding this comment.
parseHeaders() now returns an array instead of an object.
The source code and tests were updated to take it into account.
ehmicky
commented
Aug 16, 2021
| 'X-Frame-Options': ['SAMEORIGIN'], | ||
| 'X-Frame-Thing': ['SAMEORIGIN'], | ||
| 'X-Frame-Options': 'SAMEORIGIN', | ||
| 'X-Frame-Thing': 'SAMEORIGIN', |
There was a problem hiding this comment.
Multiple headers with the same name are now joined into a single one with , which is the production behavior.
The current netlify dev behavior is to set several HTTP headers instead.
So this fixes a difference between production and local experience.
JGAntunes
approved these changes
Aug 16, 2021
ehmicky
force-pushed
the
feat/use-netlify-headers-parser
branch
from
e37bae7 to
d62c747
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of netlify/build#2890
This uses
netlify-headers-parserinside Netlify CLI in order to:@netlify/configandnetlify devnetlify dev(withnetlify-redirects-parser)netlify-headers-parserI have updated the automated tests and also tested it manually.