fix: correct regex for binary types #3564
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The regex to match binary MIME types had a typo (
applicaton/octet-stream
, note the missingi
). This PR fixes that by correcting the regex so thatapplication
is only spelled once.This PR also follows the behavior documented in this forum answer where all
application/*
content types are base64 encoded except for some known text types:A picture of a cute animal (not mandatory, but encouraged)
🐫