Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(site): fix wrong regex #3930

Merged
merged 2 commits into from
Jan 3, 2022
Merged

fix(site): fix wrong regex #3930

merged 2 commits into from
Jan 3, 2022

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Jan 3, 2022 •
edited
Loading

AFAICT, this is supposed to replace only the first instance. If so, using a string is enough and this fixes the missing escape:

@XhmikosR XhmikosR marked this pull request as ready for review January 3, 2022 13:58
@XhmikosR XhmikosR requested a review from a team as a code owner January 3, 2022 13:58
@erezrokah erezrokah added the type: chore work needed to keep the product and development running smoothly label Jan 3, 2022
@erezrokah erezrokah enabled auto-merge (squash) January 3, 2022 17:09
@erezrokah erezrokah merged commit a52bdb5 into netlify:main Jan 3, 2022
@XhmikosR XhmikosR deleted the patch-1 branch January 3, 2022 18:29
gavinhenderson pushed a commit to gavinhenderson/cli that referenced this pull request Jan 5, 2022
@XhmikosR @gavinhenderson
chore(site): fix wrong regex (netlify#3930)
ee4a7de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erezrokah erezrokah erezrokah approved these changes

Assignees
No one assigned
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XhmikosR @erezrokah