-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace nyc with c8 #3939
Conversation
@erezrokah this one could go into 8.6.7 too |
This is a non user facing change, so it won't show up in the change log. We prefer very small releases as it's easier to detect regressions |
No worries. Do you have any ETA regarding the dep-related PRs? We should try to update |
I checked the relevant updates here #986, so we should start seeing those soon |
Hmm, it seems now renovate tries to update the ESM only packages... EDIT: NVM, they are fine :) Some code changes might be needed but they look good. |
Cool, I didn't know, I usually just rebase PRs here if there are conflicts, otherwise I leave them as is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't really say no to smaller install size 📦
🎉 Thanks for submitting a pull request! 🎉
Summary
https://packagephobia.com/result?p=nyc%2Cc8
1858 -> 1812 packages
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)
Requires #3933 to be merged first and then I'll rebase