Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace nyc with c8 #3939

Merged
merged 1 commit into from
Jan 7, 2022
Merged

chore: replace nyc with c8 #3939

merged 1 commit into from
Jan 7, 2022

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Jan 3, 2022

🎉 Thanks for submitting a pull request! 🎉

Summary

https://packagephobia.com/result?p=nyc%2Cc8

1858 -> 1812 packages


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)


Requires #3933 to be merged first and then I'll rebase

.gitignore Show resolved Hide resolved
@erezrokah erezrokah added the type: chore work needed to keep the product and development running smoothly label Jan 4, 2022
@XhmikosR XhmikosR marked this pull request as ready for review January 6, 2022 13:59
@XhmikosR
Copy link
Contributor Author

XhmikosR commented Jan 6, 2022

@erezrokah this one could go into 8.6.7 too

@erezrokah
Copy link
Contributor

@erezrokah this one could go into 8.6.7 too

This is a non user facing change, so it won't show up in the change log.

We prefer very small releases as it's easier to detect regressions

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Jan 6, 2022

No worries. Do you have any ETA regarding the dep-related PRs?

We should try to update http-proxy-middleware and inquirer to the latest versions since they look like they are not ESM only and they don't have any further breaking changes apart from dropping Node.js 10.x. Next I'd like to open a PR from my deps branch (minus the package.json bumps main...XhmikosR:deps

@erezrokah
Copy link
Contributor

No worries. Do you have any ETA regarding the dep-related PRs?

I checked the relevant updates here #986, so we should start seeing those soon

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Jan 6, 2022

Hmm, it seems now renovate tries to update the ESM only packages...

EDIT: NVM, they are fine :) Some code changes might be needed but they look good.

@erezrokah
Copy link
Contributor

@XhmikosR, btw we use Kodiak to efficiently sync PRs with main.

Once a PR is ready to be merged, we add an automerge label to it. Then Kodiak queues it to be merged, and sync it with main just before merging (to avoid re-running CI multiple times).

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Jan 6, 2022

Cool, I didn't know, I usually just rebase PRs here if there are conflicts, otherwise I leave them as is.

Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't really say no to smaller install size 📦

@erezrokah erezrokah merged commit b041045 into netlify:main Jan 7, 2022
@XhmikosR XhmikosR deleted the c8 branch January 7, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants